upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 00:32:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

msdosfs_rename(): implement several XXXs about downgrading to ro

Browse source 
Reviewed by:	markj
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
Differential revision:	https://reviews.freebsd.org/D43482
This commit is contained in:
Konstantin Belousov 2024-01-18 01:05:55 +02:00
parent be0df84849
commit 661db9b390
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sys/fs/msdosfs/msdosfs_vnops.c
View file

@ -1203,7 +1203,10 @@ relock:
MPASS(error == 0);
error = removede(fdip, fip);
if (error != 0) {
/* XXX should downgrade to ro here, fs is corrupt */
printf("%s: removede %s %s err %d\n",
pmp->pm_mountp->mnt_stat.f_mntonname,
fdip->de_Name, fip->de_Name, error);
msdosfs_integrity_error(pmp);
goto unlock;
}
if (!doingdirectory) {
@ -1237,7 +1240,10 @@ relock:
error = bread(pmp->pm_devvp, bn, pmp->pm_bpcluster,
NOCRED, &bp);
if (error != 0) {
/* XXX should downgrade to ro here, fs is corrupt */
printf("%s: block read error %d while renaming dir\n",
pmp->pm_mountp->mnt_stat.f_mntonname,
error);
msdosfs_integrity_error(pmp);
goto unlock;
}
dotdotp = (struct direntry *)bp->b_data + 1;
@ -1250,7 +1256,10 @@ relock:
if (DOINGASYNC(fvp))
bdwrite(bp);
else if ((error = bwrite(bp)) != 0) {
/* XXX should downgrade to ro here, fs is corrupt */
printf("%s: block write error %d while renaming dir\n",
pmp->pm_mountp->mnt_stat.f_mntonname,
error);
msdosfs_integrity_error(pmp);
goto unlock;
}
}