upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-08 16:22:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

LinuxKPI: 802.11: fix ieee80211_schedule_txq() to avoid rtw89 panic

Browse source 
rtw89 TX path was faulting in linuxkpi_ieee80211_next_txq() due to a
"double scheduling" check in linuxkpI_ieee80211_schedule_txq() being
incorrect:
the next pointer may be NULL there if the element is the last in the
tailq, so correctly check tqe_prev.  Without the fix we may have queued
the same element to the tailq twice, and because it was the last element
and had a NULL tqe_next, that NULL value would get propogated into
another node's tqe_prev on removal, and other such nastiness.

With this rtw89 no longer panics.

Reviewed by:	bz
Differential Revision: https://reviews.freebsd.org/D47006

(cherry picked from commit 41b746e052)
This commit is contained in:
Austin Shafer 2024-10-10 15:31:07 +00:00 committed by Bjoern A. Zeeb
parent d36ba3989c
commit 65de0f1855
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sys/compat/linuxkpi/common/src/linux_80211.c
View file

@ -6075,8 +6075,12 @@ void linuxkpi_ieee80211_schedule_txq(struct ieee80211_hw *hw,
if (!withoutpkts && ltxq_empty)
goto out;
/* Make sure we do not double-schedule. */
if (ltxq->txq_entry.tqe_next != NULL)
/*
* Make sure we do not double-schedule. We do this by checking tqe_prev,
* the previous entry in our tailq. tqe_prev is always valid if this entry
* is queued, tqe_next may be NULL if this is the only element in the list.
*/
if (ltxq->txq_entry.tqe_prev != NULL)
goto out;
lhw = HW_TO_LHW(hw);