upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 08:43:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't walk off the end of the array when proto isn't explicitly

Browse source 
listed above.  Instead update the catch-all "Others" bucket.

Reported by:	Coverity
CID:		1007571, 1007572
MFC after:	1 week
This commit is contained in:
Don Lewis 2016-05-16 23:47:08 +00:00
parent fb403678c2
commit 647bedd5da
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
usr.sbin/ppp/link.c
View file

@ -209,7 +209,7 @@ static struct protostatheader {
{ PROTO_LQR, "LQR" },
{ PROTO_CHAP, "CHAP" },
{ PROTO_MP, "MULTILINK" },
{ 0, "Others" }
{ 0, "Others" } /* must be last */
};
void
@ -218,13 +218,13 @@ link_ProtocolRecord(struct link *l, u_short proto, int type)
int i;
for (i = 0; i < NPROTOSTAT; i++)
if (ProtocolStat[i].number == proto)
if (ProtocolStat[i].number == proto || ProtocolStat[i].number == 0) {
if (type == PROTO_IN)
l->proto_in[i]++;
else
l->proto_out[i]++;
break;
if (type == PROTO_IN)
l->proto_in[i]++;
else
l->proto_out[i]++;
}
}
void