upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-02-18 18:20:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

net80211: amrr_init: change order of commands

Browse source 
First run the KASSERT before trying to do the free operation.
Better for reporting and debugging.
Add a guard setting the value to NULL afterwards.  NULL pointers
are a lot easier to test for.

Reviewed by:	cc
Differential Revision: https://reviews.freebsd.org/D43751

(cherry picked from commit cd9fee3d2c370e81109505c2abfd381af952e9b3)
This commit is contained in:
Bjoern A. Zeeb 2024-02-05 14:48:08 +00:00
parent fb94767f78
commit 634fd711b0
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sys/net80211/ieee80211_amrr.c
View file

@ -132,8 +132,9 @@ amrr_init(struct ieee80211vap *vap)
static void
amrr_deinit(struct ieee80211vap *vap)
{
IEEE80211_FREE(vap->iv_rs, M_80211_RATECTL);
KASSERT(nrefs > 0, ("imbalanced attach/detach"));
IEEE80211_FREE(vap->iv_rs, M_80211_RATECTL);
vap->iv_rs = NULL; /* guard */
nrefs--; /* XXX locking */
}