upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove a printf and an strlen() from the coredump code.

Browse source
This commit is contained in:
Rui Paulo 2015-02-10 18:35:46 +00:00
parent 09cfaa45eb
commit 624157bb5e
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sys/kern/kern_sig.c
View file

@ -3225,14 +3225,13 @@ out:
static int
coredump_sanitise_path(const char *path)
{
size_t len, i;
size_t i;
/*
* Only send a subset of ASCII to devd(8) because it
* might pass these strings to sh -c.
*/
len = strlen(path);
for (i = 0; i < len; i++)
for (i = 0; path[i]; i++)
if (!(isalpha(path[i]) || isdigit(path[i])) &&
path[i] != '/' && path[i] != '.' &&
path[i] != '-')
@ -3365,10 +3364,8 @@ close:
snprintf(data, sizeof(data), "comm=%s ", fullpath);
free(freepath, M_TEMP);
freepath = NULL;
if (vn_fullpath_global(td, vp, &fullpath, &freepath) != 0) {
printf("could not find coredump\n");
if (vn_fullpath_global(td, vp, &fullpath, &freepath) != 0)
goto out;
}
if (!coredump_sanitise_path(fullpath))
goto out;
strlcat(data, "core=", sizeof(data));