upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix snprintf truncation in telnet

Browse source 
Building telnet with clang 18 results in the following warning:

  contrib/telnet/telnet/telnet.c:231:5: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 11 [-Werror,-Wformat-truncation]
    231 |     snprintf(temp2, sizeof(temp2), "%c%c%c%c....%c%c", IAC, SB, TELOPT_COMPORT,
	|     ^

The temp2 buffer is 10 chars, while the format string also consists of
10 chars. Therefore, snprintf(3) will truncate the last character, 'SE'
(end sub negotation) in this case.

Bump the buffer to 11 chars to avoid truncation.

MFC after:	3 days

(cherry picked from commit c794d188222a4d3414233ff9630d47eedc090fbe)
This commit is contained in:
Dimitry Andric 2023-12-21 23:35:17 +01:00
parent f23f9c0fd2
commit 60d9bb14e8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
contrib/telnet/telnet/telnet.c
View file

@ -206,7 +206,7 @@ unsigned char ComPortBaudRate[256];
void
DoBaudRate(char *arg)
{
char *temp, temp2[10];
char *temp, temp2[11];
int i;
uint32_t baudrate;