From 5fd0916cdbfdbaad620f3d5e7ff80e3436c640ea Mon Sep 17 00:00:00 2001 From: Rick Macklem Date: Sat, 11 Feb 2023 07:14:08 -0800 Subject: [PATCH] nfsd: Add a KASSERT in nfsvno_open Commit ded5f2954e1a defined done_namei to indicate that nd_repstat was set after a successful nfsvno_namei(), so that a cleanup needs to be done in nfsvno_open(). This only happens when nfsvno_namei() is done with CREATE. This patch adds a KASSERT() to check for that. PR: 268971 --- sys/fs/nfsserver/nfs_nfsdport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index daa57222fe2..9cd7f9320bd 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -1926,6 +1926,8 @@ nfsvno_open(struct nfsrv_descript *nd, struct nameidata *ndp, } } } else if (done_namei) { + KASSERT(create == NFSV4OPEN_CREATE, + ("nfsvno_open: not create")); /* * done_namei is set when nfsvno_namei() has completed * successfully, but a subsequent error was set in