upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add a one second sleep before touching the spool directory. If the touch

Browse source 
occurs in the same second as the earlier operations to create the temporary
file and the cron(8) daemon is rescans the spool directory during that
second, then the daemon may miss a cron edit and not properly update its
internal database.

MFC after:	1 month
This commit is contained in:
John Baldwin 2012-07-02 20:27:37 +00:00
parent 7b736a7a50
commit 5cdfc55cab
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
usr.sbin/cron/crontab/crontab.c
View file

@ -608,6 +608,15 @@ replace_cmd() {
log_it(RealUser, Pid, "REPLACE", User);
/*
* Creating the 'tn' temp file has already updated the
* modification time of the spool directory. Sleep for a
* second to ensure that poke_daemon() sets a later
* modification time. Otherwise, this can race with the cron
* daemon scanning for updated crontabs.
*/
sleep(1);
poke_daemon();
return (0);