From 5b3e5c6ce3e552dae3e84d6bc781bc9f53c22d71 Mon Sep 17 00:00:00 2001 From: Konstantin Belousov Date: Tue, 30 Apr 2024 00:04:25 +0300 Subject: [PATCH] kcmp_pget(): do not accept TIDs Otherwise pget() might still look up and hold the current process. Reported and tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/kern/sys_generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/sys_generic.c b/sys/kern/sys_generic.c index cc1126ac4dc..99b018dee26 100644 --- a/sys/kern/sys_generic.c +++ b/sys/kern/sys_generic.c @@ -2098,7 +2098,8 @@ kcmp_pget(struct thread *td, pid_t pid, struct proc **pp) *pp = td->td_proc; return (0); } - error = pget(pid, PGET_CANDEBUG | PGET_NOTWEXIT | PGET_HOLD, pp); + error = pget(pid, PGET_NOTID | PGET_CANDEBUG | PGET_NOTWEXIT | + PGET_HOLD, pp); MPASS(*pp != td->td_proc); return (error); }