From 542e14a59bcaf97d7faed9f8d3fc5fed20625e3a Mon Sep 17 00:00:00 2001 From: Olivier Certner Date: Tue, 22 Apr 2025 16:26:22 +0200 Subject: [PATCH] queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() Such a guard is bound to be almost always false (obviously). Reviewed by: emaste (older version) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49974 (cherry picked from commit 613d66b5e17d92e5304fdc9abe4c62ba015ebf31) --- sys/sys/queue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/queue.h b/sys/sys/queue.h index e88e3ad69ca..5dabb1a241c 100644 --- a/sys/sys/queue.h +++ b/sys/sys/queue.h @@ -210,7 +210,7 @@ struct qm_trace { #ifndef QMD_ASSERT #define QMD_ASSERT(expression, fmt, ...) do { \ - if (!(expression)) \ + if (__predict_false(!(expression))) \ QMD_PANIC("%s:%u: %s: " fmt, \ __FILE__, __LINE__, __func__, ##__VA_ARGS__); \ } while (0)