upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-09 08:43:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

LinuxKPI: 802.11: improve lkpi_ic_vap_delete()

Browse source 
Changing the order of cleanup in lkpi_ic_vap_delete() will avoid
firmware crashes or a direct panic as observed as ieee80211_vap_detach()
will do most cleanup for us and get us into the correct state.

Calling mo_stop() in lkpi_ic_vap_delete() seems to stop the problem
that further VAPs could not be created (error 17) after the first one
being destroyed.

Sponsored by:	The FreeBSD Foundation
PR: 		269842

(cherry picked from commit dbf7691999)
(cherry picked from commit 6c38c6b1b9)
This commit is contained in:
Bjoern A. Zeeb 2023-09-30 15:20:53 +00:00
parent 493d625543
commit 53ef38313a
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sys/compat/linuxkpi/common/src/linux_80211.c
View file

@ -2424,10 +2424,17 @@ lkpi_ic_vap_delete(struct ieee80211vap *vap)
LKPI_80211_LHW_LVIF_LOCK(lhw);
TAILQ_REMOVE(&lhw->lvif_head, lvif, lvif_entry);
LKPI_80211_LHW_LVIF_UNLOCK(lhw);
lkpi_80211_mo_remove_interface(hw, vif);
ieee80211_ratectl_deinit(vap);
ieee80211_vap_detach(vap);
IMPROVE("clear up other bits in this state");
lkpi_80211_mo_remove_interface(hw, vif);
/* Single VAP, so we can do this here. */
lkpi_80211_mo_stop(hw);
mtx_destroy(&lvif->mtx);
free(lvif, M_80211_VAP);
}