From 531258ace4a7cd01d30e577359e4000280b62b70 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Tue, 5 May 2015 04:23:55 +0000 Subject: [PATCH] Add some data found in TI's application note "SCPA035: PCI1510 Implementation Guide" about default values. --- sys/dev/pccbb/pccbb_pci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/dev/pccbb/pccbb_pci.c b/sys/dev/pccbb/pccbb_pci.c index cf9b17f9374..a82afa271ed 100644 --- a/sys/dev/pccbb/pccbb_pci.c +++ b/sys/dev/pccbb/pccbb_pci.c @@ -511,6 +511,13 @@ cbb_chipinit(struct cbb_softc *sc) * register since changing them have subtle side effects * for different variants of the card and are * extremely difficult to exaustively test. + * + * Also, the TI 1510/1520 changed the default for the MFUNC + * register from 0x0 to 0x1000 to enable IRQSER by default. + * We want to be careful to avoid overriding that, and the + * below test will do that. Should this check prove to be + * too permissive, we should just check against 0 and 0x1000 + * and not touch it otherwise. */ mux = pci_read_config(sc->dev, CBBR_MFUNC, 4); sysctrl = pci_read_config(sc->dev, CBBR_SYSCTRL, 4);