From 4f9b4ac4c279650aa4f4ed7cd1b5fdfa60fbf60c Mon Sep 17 00:00:00 2001 From: Eric van Gyzen Date: Tue, 29 May 2018 20:30:46 +0000 Subject: [PATCH] pmc_annotate: adhere to the API If the 'mode' parameter was invalid, pmc_annotate() would return EINVAL instead of setting errno and returning -1. Sponsored by: Dell EMC --- lib/libpmc/libpmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/libpmc/libpmc.c b/lib/libpmc/libpmc.c index daea37c8c89..2826a250796 100644 --- a/lib/libpmc/libpmc.c +++ b/lib/libpmc/libpmc.c @@ -2781,7 +2781,8 @@ pmc_allocate(const char *ctrspec, enum pmc_mode mode, if (mode != PMC_MODE_SS && mode != PMC_MODE_TS && mode != PMC_MODE_SC && mode != PMC_MODE_TC) { - return (EINVAL); + errno = EINVAL; + goto out; } bzero(&pmc_config, sizeof(pmc_config)); pmc_config.pm_cpu = cpu;