From 4eaede87b025d198734babcc8dc98ff356f41d19 Mon Sep 17 00:00:00 2001 From: John-Mark Gurney Date: Sun, 2 Mar 1997 14:03:33 +0000 Subject: [PATCH] add the same fix to pcvt that I did to syscons. Make sure that the signals provided by the user are valid else return EINVAL. Reviewed-by: joerg --- sys/i386/isa/pcvt/pcvt_ext.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sys/i386/isa/pcvt/pcvt_ext.c b/sys/i386/isa/pcvt/pcvt_ext.c index e8a75bb77d5..b27575f351a 100644 --- a/sys/i386/isa/pcvt/pcvt_ext.c +++ b/sys/i386/isa/pcvt/pcvt_ext.c @@ -72,6 +72,8 @@ #include /* global include */ +#define ISSIGVALID(sig) ((sig) > 0 && (sig) < NSIG) + static int s3testwritable( void ); static int et4000_col( int ); static int wd90c11_col( int ); @@ -2505,9 +2507,15 @@ usl_vt_ioctl(Dev_t dev, int cmd, caddr_t data, int flag, struct proc *p) return EBUSY; /* already in use on this VT */ } - vsp->smode = newmode; - vsp->proc = p; - vsp->pid = p->p_pid; + if (ISSIGVALID(newmode->relsig) && ISSIGVALID(newmode->acqsig) + && ISSIGVALID(newmode->frsig)) { + vsp->smode = newmode; + vsp->proc = p; + vsp->pid = p->p_pid; + } else { + splx(opri); + return EINVAL; + } #if PCVT_FREEBSD > 206 /*