From 4cb1e53914f0333c68cecbac7c3e4ca054cd84be Mon Sep 17 00:00:00 2001 From: Mark Murray Date: Sat, 2 Dec 2000 16:23:54 +0000 Subject: [PATCH] Recouple arc4random(9) to the entropy device. This works whether the entropy device is loaded or not. If the entropy device is NOT loaded, the the quality of perturbations supplied by this will suffer. --- sys/libkern/arc4random.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/libkern/arc4random.c b/sys/libkern/arc4random.c index 9abba830a92..477c7426997 100644 --- a/sys/libkern/arc4random.c +++ b/sys/libkern/arc4random.c @@ -40,8 +40,10 @@ arc4_randomstir (void) u_int8_t key[256]; int r, n; - /* r = read_random(key, sizeof(key)); */ - r = 0; /* XXX MarkM - revisit this when /dev/random is done */ + /* XXX read_random() returns unsafe numbers if the entropy + * devce is not loaded - MarkM + */ + r = read_random(key, sizeof(key)); /* if r == 0 || -1, just use what was on the stack */ if (r > 0) {