From 49f1151fb6bfa0f0bea4a85120ba505a1bf8e2a4 Mon Sep 17 00:00:00 2001 From: Nathan Whitehorn Date: Thu, 11 Oct 2018 00:54:39 +0000 Subject: [PATCH] Loader GELI support, like lua loader, seems to be broken on PowerPC as well as on SPARC64 and can cause boot failures even when no encrypted disks are present. Presumably, the reasons, while unknown, are the same and most-likely are the result of some endian-unsafe code. Pending finding the actual problem, extend the blacklist entry for these parts of loader on SPARC to also cover all PowerPC platforms. Approved by: re (kib) --- share/mk/src.opts.mk | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk index d6f1d8e4b5b..e1346cfa29c 100644 --- a/share/mk/src.opts.mk +++ b/share/mk/src.opts.mk @@ -353,16 +353,13 @@ BROKEN_OPTIONS+=LOADER_OFW .if ${__T:Marm*} == "" && ${__T:Mmips*} == "" && ${__T:Mpowerpc*} == "" BROKEN_OPTIONS+=LOADER_UBOOT .endif -# GELI and Lua in loader currently cause boot failures on sparc64. -# Further debugging is required. -.if ${__T} == "sparc64" +# GELI and Lua in loader currently cause boot failures on sparc64 and powerpc. +# Further debugging is required -- probably they are just broken on big +# endian systems generically (they jump to null pointers or try to read +# crazy high addresses, which is typical of endianness problems). +.if ${__T} == "sparc64" || ${__T:Mpowerpc*} BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA .endif -# Lua in loader currently cause boot failures on powerpc. -# Further debugging is required. -.if ${__T} == "powerpc" || ${__T} == "powerpc64" -BROKEN_OPTIONS+=LOADER_LUA -.endif .if ${__T:Mmips64*} # profiling won't work on MIPS64 because there is only assembly for o32