From 44fbcadd83ce9ba369250df220b9e8529d85f3e8 Mon Sep 17 00:00:00 2001 From: David Bright Date: Fri, 22 Feb 2019 18:43:27 +0000 Subject: [PATCH] CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c A pointer is first tested for NULL. If non-NULL, another pointer is set equal to the first. The second pointer is then checked for NULL and an error path taken if so. This second test and the associated path is dead code as the pointer value, having just been checked for NULL, cannot be NULL at this point. Remove the dead code. Reported by: Coverity Reviewed by: daniel.william.ryan_gmail.com, vangyzen Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D19165 --- sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c b/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c index 5147f806688..c7d0ca08564 100644 --- a/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c +++ b/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c @@ -1820,12 +1820,6 @@ tiNumOfLunIOCTLreq( break; } tdIORequestBody = (tdIORequestBody_t *)tiRequestBody; - - if(tdIORequestBody == agNULL) - { - status = IOCTL_CALL_FAIL; - break; - } tdIORequestBody->tiIORequest = tiIORequest; /* save context if we need to abort later */