upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-08 08:12:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

dwc: re-rewrite barrier part

Browse source 
We need the DMA engine to have everything coherent *before* we
set the OWN bit (the bit that tells the DMA engine that it owns
the descriptor).

Fixes:	487034648805 ("dwc: Rewrite barrier part")

Reported by:	jhb
This commit is contained in:
Emmanuel Vadot 2023-10-12 20:54:52 +02:00
parent 944223076f
commit 43cd6bbba0
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sys/dev/dwc/dwc1000_dma.c
View file

@ -216,8 +216,8 @@ txdesc_setup(struct dwc_softc *sc, int idx, bus_addr_t paddr,
sc->txdesc_ring[idx].addr1 = (uint32_t)(paddr);
sc->txdesc_ring[idx].desc0 = desc0;
sc->txdesc_ring[idx].desc1 = desc1;
sc->txdesc_ring[idx].desc0 |= TDESC0_OWN;
wmb();
sc->txdesc_ring[idx].desc0 |= TDESC0_OWN;
}
inline static uint32_t
@ -236,8 +236,8 @@ rxdesc_setup(struct dwc_softc *sc, int idx, bus_addr_t paddr)
sc->rxdesc_ring[idx].desc1 = ERDESC1_RCH |
MIN(MCLBYTES, ERDESC1_RBS1_MASK);
sc->rxdesc_ring[idx].desc0 = RDESC0_OWN;
wmb();
sc->rxdesc_ring[idx].desc0 = RDESC0_OWN;
return (nidx);
}
@ -522,8 +522,8 @@ dma1000_rxfinish_locked(struct dwc_softc *sc)
m = dwc_rxfinish_one(sc, desc, sc->rxbuf_map + idx);
if (m == NULL) {
desc->desc0 = RDESC0_OWN;
wmb();
desc->desc0 = RDESC0_OWN;
} else {
/* We cannot create hole in RX ring */
error = dma1000_setup_rxbuf(sc, idx, m);