From 42e1b74af276f768b4b65c845e26d36d7542f468 Mon Sep 17 00:00:00 2001 From: Alfred Perlstein Date: Tue, 11 Feb 2003 07:20:52 +0000 Subject: [PATCH] Don't lock FILEDESC under PROC. The locking here needs to be revisited, but this ought to get rid of the LOR messages that people are complaining about for now. I imagine either I or someone else interested with smp will eventually clear this up. --- sys/kern/kern_descrip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c index 140fb80aa40..fe52ec1bfe4 100644 --- a/sys/kern/kern_descrip.c +++ b/sys/kern/kern_descrip.c @@ -2104,8 +2104,8 @@ sysctl_kern_file(SYSCTL_HANDLER_ARGS) PROC_LOCK(p); xf.xf_pid = p->p_pid; xf.xf_uid = p->p_ucred->cr_uid; + PROC_UNLOCK(p); if ((fdp = p->p_fd) == NULL) { - PROC_UNLOCK(p); continue; } FILEDESC_LOCK(fdp); @@ -2125,7 +2125,6 @@ sysctl_kern_file(SYSCTL_HANDLER_ARGS) break; } FILEDESC_UNLOCK(fdp); - PROC_UNLOCK(p); if (error) break; }