From 4194e4e371a17012b42bcc5afe118c2c2b2792a2 Mon Sep 17 00:00:00 2001 From: "Pedro F. Giffuni" Date: Mon, 20 Apr 2015 22:09:50 +0000 Subject: [PATCH] Fix improbable memory leak in _citrus_prop_read_str(). Found by: Clang Static Analyzer --- lib/libc/iconv/citrus_prop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libc/iconv/citrus_prop.c b/lib/libc/iconv/citrus_prop.c index 28318de05a3..642e4230986 100644 --- a/lib/libc/iconv/citrus_prop.c +++ b/lib/libc/iconv/citrus_prop.c @@ -293,8 +293,10 @@ done: } _memstream_ungetc(ms, ch); errnum = _citrus_prop_read_character_common(ms, &ch); - if (errnum != 0) + if (errnum != 0) { + free(s); return (errnum); + } s[n] = ch; ++n, --m; }