From 3f2792166aeed4baf07d351bcb12a9d196c443eb Mon Sep 17 00:00:00 2001
From: Michael Tuexen <tuexen@FreeBSD.org>
Date: Thu, 26 Sep 2024 08:02:06 +0200
Subject: [PATCH] MAC: improve consistency in error handling

Whenever mac_syncache_init() returns an error, ensure that
*label = NULL. This simplifies the error handling by the caller.

Reviewed by:		rscheff
MFC after:		1 week
Sponsored by:		Netflix, Inc.
Differential Revision:	https://reviews.freebsd.org/D46701
---
 sys/security/mac/mac_inet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/security/mac/mac_inet.c b/sys/security/mac/mac_inet.c
index 29a35507106..9770fa840f9 100644
--- a/sys/security/mac/mac_inet.c
+++ b/sys/security/mac/mac_inet.c
@@ -485,6 +485,7 @@ mac_syncache_init(struct label **label)
 			MAC_POLICY_PERFORM_NOSLEEP(syncache_destroy_label,
 			    *label);
 			mac_labelzone_free(*label);
+			*label = NULL;
 		}
 		return (error);
 	} else