From 3b234fcbab2a6fdb9c1a06707f222afa4d8cff33 Mon Sep 17 00:00:00 2001 From: Pyun YongHyeon Date: Wed, 2 Aug 2006 02:36:59 +0000 Subject: [PATCH] Fix incorrect busy check for PHY write operation. While I'm here remove unnecessary return statement. --- sys/dev/sk/if_sk.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/sk/if_sk.c b/sys/dev/sk/if_sk.c index 22c50b84216..184d7e88ed5 100644 --- a/sys/dev/sk/if_sk.c +++ b/sys/dev/sk/if_sk.c @@ -793,13 +793,11 @@ sk_marv_miibus_writereg(sc_if, phy, reg, val) for (i = 0; i < SK_TIMEOUT; i++) { DELAY(1); - if (SK_YU_READ_2(sc_if, YUKON_SMICR) & YU_SMICR_BUSY) + if ((SK_YU_READ_2(sc_if, YUKON_SMICR) & YU_SMICR_BUSY) == 0) break; } - if (i == SK_TIMEOUT) { + if (i == SK_TIMEOUT) if_printf(sc_if->sk_ifp, "phy write timeout\n"); - return (0); - } return(0); }