upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add missing NULL checks when calling malloc(M_NOWAIT) in

Browse source 
bhnd_nv_strdup/bhnd_nv_strndup.

If malloc(9) failed during initial bhnd(4) attach, while allocating the root
NVRAM path string ("/"), the returned NULL pointer would be passed as the
destination to memcpy().

Reported by:	Ilja Van Sprundel <ivansprundel@ioactive.com>
This commit is contained in:
Landon J. Fuller 2018-03-22 22:13:46 +00:00
parent 5cbeca4497
commit 397b9e40e9
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sys/dev/bhnd/nvram/bhnd_nvram_private.h
View file

@ -91,6 +91,9 @@ bhnd_nv_strdup(const char *str)
len = strlen(str);
dest = malloc(len + 1, M_BHND_NVRAM, M_NOWAIT);
if (dest == NULL)
return (NULL);
memcpy(dest, str, len);
dest[len] = '\0';
@ -105,6 +108,9 @@ bhnd_nv_strndup(const char *str, size_t len)
len = strnlen(str, len);
dest = malloc(len + 1, M_BHND_NVRAM, M_NOWAIT);
if (dest == NULL)
return (NULL);
memcpy(dest, str, len);
dest[len] = '\0';