Clean up FreeBSD-specific header file:

- Define ACPI_USE_DO_WHILE_0 to add do while(0) around return_*() macros.
- Define __cdecl only for user land.  It will never be used in kernel.
- Remove __cli() and __sti().  They were deprecated long ago.

sys/contrib/dev/acpica/include/platform/acfreebsd.h

@@ -125,11 +125,10 @@
 
 #define	ACPI_UINTPTR_T		uintptr_t
 
+#define	ACPI_USE_DO_WHILE_0
 #define	ACPI_USE_LOCAL_CACHE
 #define	ACPI_USE_SYSTEM_CLIBRARY
 
-#define	__cdecl
-
 #ifdef _KERNEL
 
 #include <sys/ctype.h>
@@ -168,12 +167,10 @@
 
 #define	ACPI_THREAD_ID		pthread_t
 
-/* Not building kernel code, so use libc */
 #define	ACPI_USE_STANDARD_HEADERS
-#define	ACPI_FLUSH_CPU_CACHE()
 
-#define	__cli()
-#define	__sti()
+#define	ACPI_FLUSH_CPU_CACHE()
+#define	__cdecl
 
 #endif /* _KERNEL */