mirror of
https://github.com/opnsense/src.git
synced 2026-02-19 02:30:08 -05:00
calendar: don't setlogin(2) in the -a user handlers
As ofe67975d331("Fix 'calendar -a' in several ways."), `calendar -a` will now fork off a new process for each user and do all of its own processing in the user's own context. As a side-effect, calendar(1) started calling setlogin(2) in each of the forked processes and inadvertently hijacked the login name for the session it was running under, which was typically not a fresh session but rather that of whatever cron/periodic run spawned it. Thus, daily and security e-mails started coming from completely arbitrary user. We could create a new session, but it appears that nothing calendar(1) does really needs the login name to be clobbered; opt to just avoid the setlogin(2) call entirely rather than incur the overhead of a new session for each process. PR: 280418 Reviewed by: des, olce Fixes:e67975d331("Fix 'calendar -a' in several ways.") (cherry picked from commit 6cb8b61efe8899ee9194563108d0ae90c1eb89e3)
This commit is contained in:
parent
40c79e979e
commit
33708452aa
1 changed files with 1 additions and 1 deletions
|
|
@ -224,7 +224,7 @@ main(int argc, char *argv[])
|
|||
|
||||
lc = login_getpwclass(pw);
|
||||
if (setusercontext(lc, pw, pw->pw_uid,
|
||||
LOGIN_SETALL) != 0)
|
||||
LOGIN_SETALL & ~LOGIN_SETLOGIN) != 0)
|
||||
errx(1, "setusercontext");
|
||||
setenv("HOME", pw->pw_dir, 1);
|
||||
cal();
|
||||
|
|
|
|||
Loading…
Reference in a new issue