From 335dd8f82feae7d4f13d1d59193c41daf6cddac7 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky Date: Thu, 1 Mar 2012 20:10:54 +0000 Subject: [PATCH] Close a detach race. Make sure all pending CCB's get canceled at device detach. MFC after: 1 week --- sys/dev/usb/storage/umass.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dev/usb/storage/umass.c b/sys/dev/usb/storage/umass.c index 3f2bd11f88d..863745bb90c 100644 --- a/sys/dev/usb/storage/umass.c +++ b/sys/dev/usb/storage/umass.c @@ -1056,6 +1056,11 @@ umass_detach(device_t dev) #if (__FreeBSD_version >= 700037) mtx_lock(&sc->sc_mtx); #endif + + /* cancel any leftover CCB's */ + + umass_cancel_ccb(sc); + umass_cam_detach_sim(sc); #if (__FreeBSD_version >= 700037) @@ -1607,8 +1612,7 @@ umass_command_start(struct umass_softc *sc, uint8_t dir, if (sc->sc_xfer[sc->sc_last_xfer_index]) { usbd_transfer_start(sc->sc_xfer[sc->sc_last_xfer_index]); } else { - ccb->ccb_h.status = CAM_TID_INVALID; - xpt_done(ccb); + umass_cancel_ccb(sc); } }