upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bhyve: avoid an empty passthru config value

Browse source 
pci_parse_legacy_config splits the options string by comma characters.
strchr returns a pointer to the first occurence of a character. In that
case, it's a comma. So, pci_parse_legacy_config will stop at the first
character and creates a new config node with a name of NULL.

Reviewed by:	jhb
Differential Revision:	https://reviews.freebsd.org/D34600
This commit is contained in:
Corvin Köhne 2022-04-01 10:20:55 +02:00 committed by Emmanuel Vadot
parent 8ac8adda8d
commit 3256b7ca36
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
usr.sbin/bhyve/pci_passthru.c
View file

@ -662,7 +662,12 @@ passthru_legacy_config(nvlist_t *nvl, const char *opts)
snprintf(value, sizeof(value), "%d", func);
set_config_value_node(nvl, "func", value);
return (pci_parse_legacy_config(nvl, strchr(opts, ',')));
opts = strchr(opts, ',');
if (opts == NULL) {
return (0);
}
return pci_parse_legacy_config(nvl, opts + 1);
}
static int