From 2eddfeaaf0a969e00899c52080295edc499dee79 Mon Sep 17 00:00:00 2001 From: Ruslan Ermilov Date: Thu, 8 Mar 2007 21:10:53 +0000 Subject: [PATCH] ng_send_fn() can return with an error, the function of interest will never be called and OACTIVE will never be reset. Fix this. Submitted by: Vsevolod Lobko MFC after: 3 days --- sys/netgraph/ng_eiface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_eiface.c b/sys/netgraph/ng_eiface.c index bef1c267204..a38abe36470 100644 --- a/sys/netgraph/ng_eiface.c +++ b/sys/netgraph/ng_eiface.c @@ -277,7 +277,8 @@ ng_eiface_start(struct ifnet *ifp) ifp->if_drv_flags |= IFF_DRV_OACTIVE; - ng_send_fn(priv->node, NULL, &ng_eiface_start2, ifp, 0); + if (ng_send_fn(priv->node, NULL, &ng_eiface_start2, ifp, 0) != 0) + ifp->if_drv_flags &= ~IFF_DRV_OACTIVE; } #ifdef DEBUG