upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fbd: Fix a bug where vt_fb_attach() success would be considered a failure

Browse source 
vt_fb_attach() currently always returns 0, but it could return a code
defined in errno.h. However, it doesn't return a CN_* code. So checking
its return value against CN_DEAD (which is 0) is incorrect, and in this
case, a success becomes a failure.

The consequence was unimportant, because the caller (drm_fb_helper.c)
would only log an error message in this case. The console would still
work.

Approved by:	nwhitehorn
This commit is contained in:
Jean-Sébastien Pédron 2014-08-10 14:55:39 +00:00
parent 31f92dec23
commit 2cf9e30b6e
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/dev/fb/fbd.c
View file

@ -246,8 +246,9 @@ fbd_register(struct fb_info* info)
return (err);
if (first) {
if (vt_fb_attach(info) == CN_DEAD)
return (ENXIO);
err = vt_fb_attach(info);
if (err)
return (err);
}
return (0);