From 2ca9ffa9bb2da931f3055a5bdbf58ce956d36a5f Mon Sep 17 00:00:00 2001 From: Ed Schouten Date: Wed, 1 Jun 2016 20:45:21 +0000 Subject: [PATCH] Don't call setgrent() in an unportable way. For FreeBSD 12, I'm considering updating setgrent() to have a function prototype that conforms to POSIX. FreeBSD seems to be the only operating system that lets setgrent() return an integer. It's also inconsistent with setpwent(). It looks like our libcasper depends on setgrent() returning an integer. Get rid of that. Reviewed by: oshogbo Differential Revision: https://reviews.freebsd.org/D6659 --- lib/libcasper/services/cap_grp/cap_grp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libcasper/services/cap_grp/cap_grp.c b/lib/libcasper/services/cap_grp/cap_grp.c index d358cea9588..54a022f76ce 100644 --- a/lib/libcasper/services/cap_grp/cap_grp.c +++ b/lib/libcasper/services/cap_grp/cap_grp.c @@ -703,7 +703,9 @@ grp_setgrent(const nvlist_t *limits __unused, const nvlist_t *nvlin __unused, nvlist_t *nvlout __unused) { - return (setgrent() == 0 ? EFAULT : 0); + setgrent(); + + return (0); } static int