From 273c749c93cfcc186f524281a6ae59bc8f7be033 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky Date: Sat, 25 May 2013 17:09:58 +0000 Subject: [PATCH] Fix some statical clang analyzer warnings. --- sys/dev/usb/usb_device.c | 3 --- sys/dev/usb/usb_hub.c | 1 - sys/dev/usb/usb_msctest.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/dev/usb/usb_device.c b/sys/dev/usb/usb_device.c index 82bcd7062a7..7e8181c06f8 100644 --- a/sys/dev/usb/usb_device.c +++ b/sys/dev/usb/usb_device.c @@ -799,9 +799,6 @@ usb_config_parse(struct usb_device *udev, uint8_t iface_index, uint8_t cmd) /* find maximum number of endpoints */ if (ep_max < temp) ep_max = temp; - - /* optimalisation */ - id = (struct usb_interface_descriptor *)ed; } } diff --git a/sys/dev/usb/usb_hub.c b/sys/dev/usb/usb_hub.c index 227f31730f6..f82ff9baa93 100644 --- a/sys/dev/usb/usb_hub.c +++ b/sys/dev/usb/usb_hub.c @@ -341,7 +341,6 @@ uhub_reattach_port(struct uhub_softc *sc, uint8_t portno) DPRINTF("reattaching port %d\n", portno); - err = 0; timeout = 0; udev = sc->sc_udev; child = usb_bus_port_get_device(udev->bus, diff --git a/sys/dev/usb/usb_msctest.c b/sys/dev/usb/usb_msctest.c index 1f0598ab62c..a9b90550381 100644 --- a/sys/dev/usb/usb_msctest.c +++ b/sys/dev/usb/usb_msctest.c @@ -802,7 +802,6 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method) if (sc == NULL) return (USB_ERR_INVAL); - err = 0; switch (method) { case MSC_EJECT_STOPUNIT: err = bbb_command_start(sc, DIR_IN, 0, NULL, 0, @@ -844,6 +843,7 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method) break; default: DPRINTF("Unknown eject method (%d)\n", method); + err = 0; break; } DPRINTF("Eject CD command status: %s\n", usbd_errstr(err));