diff --git a/sys/dev/iscsi/icl_soft.c b/sys/dev/iscsi/icl_soft.c index 38eb530e549..401b0ddc215 100644 --- a/sys/dev/iscsi/icl_soft.c +++ b/sys/dev/iscsi/icl_soft.c @@ -954,7 +954,6 @@ icl_conn_send_pdus(struct icl_conn *ic, struct icl_pdu_stailq *queue) request = STAILQ_FIRST(queue); size = icl_pdu_size(request); if (available < size) { - /* * Set the low watermark, to be checked by * sowriteable() in icl_soupcall_send() diff --git a/sys/dev/iscsi/icl_soft_proxy.c b/sys/dev/iscsi/icl_soft_proxy.c index fdfeb48081f..e330be88fb9 100644 --- a/sys/dev/iscsi/icl_soft_proxy.c +++ b/sys/dev/iscsi/icl_soft_proxy.c @@ -192,7 +192,7 @@ icl_listen_free(struct icl_listen *il) pause("icl_unlisten", 1 * hz); sx_xlock(&il->il_lock); } - + TAILQ_REMOVE(&il->il_sockets, ils, ils_next); soclose(ils->ils_socket); free(ils, M_ICL_PROXY); @@ -326,7 +326,6 @@ icl_listen_add(struct icl_listen *il, bool rdma, int domain, int socktype, return (EOPNOTSUPP); } - return (icl_listen_add_tcp(il, domain, socktype, protocol, sa, portal_id)); } diff --git a/sys/dev/iscsi/iscsi.c b/sys/dev/iscsi/iscsi.c index aa426392aba..9663106cf05 100644 --- a/sys/dev/iscsi/iscsi.c +++ b/sys/dev/iscsi/iscsi.c @@ -398,14 +398,14 @@ iscsi_maintenance_thread_reconnect(struct iscsi_session *is) } cv_signal(&is->is_login_cv); #endif - + if (fail_on_disconnection) { ISCSI_SESSION_DEBUG(is, "connection failed, destroying devices"); iscsi_session_cleanup(is, true); } else { iscsi_session_cleanup(is, false); } - + KASSERT(TAILQ_EMPTY(&is->is_outstanding), ("destroying session with active tasks")); KASSERT(STAILQ_EMPTY(&is->is_postponed), @@ -1037,7 +1037,7 @@ iscsi_pdu_handle_data_in(struct icl_pdu *response) union ccb *ccb; struct ccb_scsiio *csio; size_t data_segment_len, received, oreceived; - + is = PDU_SESSION(response); bhsdi = (struct iscsi_bhs_data_in *)response->ip_bhs; io = iscsi_outstanding_find(is, bhsdi->bhsdi_initiator_task_tag); diff --git a/sys/dev/iscsi_initiator/isc_cam.c b/sys/dev/iscsi_initiator/isc_cam.c index 84004d7639b..d14856de8e3 100644 --- a/sys/dev/iscsi_initiator/isc_cam.c +++ b/sys/dev/iscsi_initiator/isc_cam.c @@ -211,7 +211,7 @@ ic_action(struct cam_sim *sim, union ccb *ccb) return; break; } - + case XPT_CALC_GEOMETRY: { struct ccb_calc_geometry *ccg; @@ -330,7 +330,6 @@ ic_init(isc_session_t *sp) if(xpt_bus_register(sim, NULL, 0/*bus_number*/) != CAM_SUCCESS) { - cam_sim_free(sim, /*free_devq*/TRUE); mtx_destroy(&sp->cam_mtx); return ENXIO; diff --git a/sys/dev/iscsi_initiator/iscsi.c b/sys/dev/iscsi_initiator/iscsi.c index a081ecc7bbe..19c45f87d13 100644 --- a/sys/dev/iscsi_initiator/iscsi.c +++ b/sys/dev/iscsi_initiator/iscsi.c @@ -370,7 +370,6 @@ iscsi_read(struct cdev *dev, struct uio *uio, int ioflag) sprintf(buf, "/---- socket -----/\nso_count=%d so_state=%x\n", so->so_count, so->so_state); uiomove(buf, strlen(buf), uio); - } #endif return 0; @@ -749,7 +748,7 @@ iscsi_start(void) iscsi_driver_version, 0, "iscsi driver version"); - + SYSCTL_ADD_STRING(&isc->clist, SYSCTL_CHILDREN(isc->oid), OID_AUTO, diff --git a/sys/dev/iscsi_initiator/iscsi_subr.c b/sys/dev/iscsi_initiator/iscsi_subr.c index 2311e1fc7cb..e3fa9b79f5a 100644 --- a/sys/dev/iscsi_initiator/iscsi_subr.c +++ b/sys/dev/iscsi_initiator/iscsi_subr.c @@ -409,7 +409,7 @@ iscsi_reject(isc_session_t *sp, pduq_t *opq, pduq_t *pq) //XXX: check RFC 10.17.1 (page 176) ccb->ccb_h.status = CAM_REQ_ABORTED; xpt_done(ccb); - + pdu_free(sp->isc, opq); }