From 1f8bdab601bc35c7fa61a02a0e4b160b5eb699fb Mon Sep 17 00:00:00 2001 From: Rick Macklem Date: Mon, 30 Dec 2019 22:39:29 +0000 Subject: [PATCH] Add warning printf w.r.t. removal of sys/nfs/nfs_lock.c. The code in sys/nfs/nfs_lock.c has not been run by default since March 2008 when it was replaced by the in kernel sys/nlm code. It uses Giant, so it needs to be removed before the FreeBSD 13 release. This will happen in a couple of months, since few if any users run the code anyhow and can easily switch to the default in kernel NFSLOCKD. --- sys/nfs/nfs_lock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/nfs/nfs_lock.c b/sys/nfs/nfs_lock.c index efa1e80b5b7..6ebb7e83ff2 100644 --- a/sys/nfs/nfs_lock.c +++ b/sys/nfs/nfs_lock.c @@ -89,6 +89,8 @@ nfslock_open(struct cdev *dev, int oflags, int devtype, struct thread *td) { int error; + printf("WARNING: uses Giant and will be removed before FreeBSD 13\n" + "\tuse the kernel NFSLOCKD/nfslockd.ko\n"); error = priv_check(td, PRIV_NFS_LOCKD); if (error) return (error);