Added undocumented options AAC_DEBUG, ACD_DEBUG, ACPI_MAX_THREADS,

ACPI_NO_SEMAPHORES, ASR_MEASURE_PERFORMANCE, AST_DEBUG, ATAPI_DEBUG,
ATA_DEBUG, BKTR_ALLOC_PAGES, BROOKTREE_ALLOC_PAGES, CAPABILITIES,
COMPAT_SUNOS, CV_DEBUG, MAXFILES, METEOR_TEST_VIDEO, NDEVFSINO,
NDEVFSOVERFLOW, NETGRAPH_BRIDGE, NETSMB, NETSMBCRYPTO, PFIL_HOOKS,
SIMOS, SMBFS, VESA_DEBUG, VGA_DEBUG.

Start using #! to comment out negative options and ## to comment out
broken options.

atapi-all.c:
Fixed rotted bits that were hiding under ATAPI_DEBUG.

atapi-cd.c:
#include "opt_ata.h" so that ACD_DEBUG is actually visible.

ata/atapi-tape.c
#include "opt_ata.h" so that AST_DEBUG is actually visible.

sys/conf/NOTES

@@ -3021,3 +3021,38 @@ options 	VFS_BIO_DEBUG	# VFS buffer I/O debugging
 options 	VM_KMEM_SIZE
 options 	VM_KMEM_SIZE_MAX
 options 	VM_KMEM_SIZE_SCALE
+
+# Yet more undocumented options for linting.
+options 	AAC_DEBUG
+options 	ACD_DEBUG
+options 	ACPI_MAX_THREADS=1
+#!options 	ACPI_NO_SEMAPHORES
+# Broken:
+##options 	ASR_MEASURE_PERFORMANCE
+options 	AST_DEBUG
+options 	ATAPI_DEBUG
+options 	ATA_DEBUG
+# BKTR_ALLOC_PAGES has no effect except to cause warnings, and
+# BROOKTREE_ALLOC_PAGES hasn't actually been superseded by it, since the
+# driver still mostly spells this option BROOKTREE_ALLOC_PAGES.
+##options 	BKTR_ALLOC_PAGES="(217*4+1)"
+options 	BROOKTREE_ALLOC_PAGES="(217*4+1)"
+# Broken:
+##options 	CAPABILITIES
+options 	COMPAT_SUNOS
+options 	CV_DEBUG
+options 	MAXFILES=999
+# METEOR_TEST_VIDEO has no effect since meteor is broken.
+options 	METEOR_TEST_VIDEO
+options 	NDEVFSINO=1025
+options 	NDEVFSOVERFLOW=32769
+options 	NETGRAPH_BRIDGE
+options 	NETSMB
+options 	NETSMBCRYPTO
+# PFIL_HOOKS has no effect here since it is a subset of IPFILTER.
+options 	PFIL_HOOKS
+# SIMOS is broken since it is alpha-only but not ifdefed.
+##options 	SIMOS
+options 	SMBFS
+options 	VESA_DEBUG
+options 	VGA_DEBUG

sys/dev/ata/atapi-all.c

@@ -587,7 +587,7 @@ static void
 atapi_finish(struct atapi_request *request)
 {
 #ifdef ATAPI_DEBUG
-    ata_prtdev(atadev->device->device, "finished %s%s\n",
+    ata_prtdev(request->device, "finished %s%s\n",
 	       request->callback ? "callback " : "",
 	       atapi_cmd2str(request->ccb[0]));
 #endif

sys/dev/ata/atapi-cd.c

@@ -28,6 +28,8 @@
  * $FreeBSD$
  */
 
+#include "opt_ata.h"
+
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/ata.h>

sys/dev/ata/atapi-tape.c

@@ -28,6 +28,8 @@
  * $FreeBSD$
  */
 
+#include "opt_ata.h"
+
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/ata.h>

sys/i386/conf/NOTES

@@ -3021,3 +3021,38 @@ options 	VFS_BIO_DEBUG	# VFS buffer I/O debugging
 options 	VM_KMEM_SIZE
 options 	VM_KMEM_SIZE_MAX
 options 	VM_KMEM_SIZE_SCALE
+
+# Yet more undocumented options for linting.
+options 	AAC_DEBUG
+options 	ACD_DEBUG
+options 	ACPI_MAX_THREADS=1
+#!options 	ACPI_NO_SEMAPHORES
+# Broken:
+##options 	ASR_MEASURE_PERFORMANCE
+options 	AST_DEBUG
+options 	ATAPI_DEBUG
+options 	ATA_DEBUG
+# BKTR_ALLOC_PAGES has no effect except to cause warnings, and
+# BROOKTREE_ALLOC_PAGES hasn't actually been superseded by it, since the
+# driver still mostly spells this option BROOKTREE_ALLOC_PAGES.
+##options 	BKTR_ALLOC_PAGES="(217*4+1)"
+options 	BROOKTREE_ALLOC_PAGES="(217*4+1)"
+# Broken:
+##options 	CAPABILITIES
+options 	COMPAT_SUNOS
+options 	CV_DEBUG
+options 	MAXFILES=999
+# METEOR_TEST_VIDEO has no effect since meteor is broken.
+options 	METEOR_TEST_VIDEO
+options 	NDEVFSINO=1025
+options 	NDEVFSOVERFLOW=32769
+options 	NETGRAPH_BRIDGE
+options 	NETSMB
+options 	NETSMBCRYPTO
+# PFIL_HOOKS has no effect here since it is a subset of IPFILTER.
+options 	PFIL_HOOKS
+# SIMOS is broken since it is alpha-only but not ifdefed.
+##options 	SIMOS
+options 	SMBFS
+options 	VESA_DEBUG
+options 	VGA_DEBUG