From 197b023b1b33c021e68f9286e5f5a26fdd266478 Mon Sep 17 00:00:00 2001 From: Ian Dowse Date: Mon, 7 Oct 2002 20:49:22 +0000 Subject: [PATCH] Add back a fdrop() call at the end of kern_open() that got lost in revision 1.218. This bug caused a "struct file" reference to be leaked if VOP_ADVLOCK(), vn_start_write(), or mac_check_vnode_write() failed during the open operation. PR: kern/43739 Reported by: Arne Woerner --- sys/kern/vfs_extattr.c | 1 + sys/kern/vfs_syscalls.c | 1 + 2 files changed, 2 insertions(+) diff --git a/sys/kern/vfs_extattr.c b/sys/kern/vfs_extattr.c index 4cba8b5960c..55ec3161227 100644 --- a/sys/kern/vfs_extattr.c +++ b/sys/kern/vfs_extattr.c @@ -773,6 +773,7 @@ bad: fdrop(fp, td); } else FILEDESC_UNLOCK(fdp); + fdrop(fp, td); return (error); } diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 4cba8b5960c..55ec3161227 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -773,6 +773,7 @@ bad: fdrop(fp, td); } else FILEDESC_UNLOCK(fdp); + fdrop(fp, td); return (error); }