upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-08 16:22:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Properly drop group privs to open file names specified by the user.

Browse source 
Submitted by:	Niall Smart rotel@indigo.ie
Obtained from:	OpenBSD (rev 1.7 and 1.8)
This commit is contained in:
Warner Losh 1997-12-30 05:13:21 +00:00
parent f0da8de186
commit 15678bfa03
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
sbin/ccdconfig/ccdconfig.c
View file

@ -1,4 +1,4 @@
/* $Id: ccdconfig.c,v 1.6 1997/02/22 14:32:10 peter Exp $ */
/* $Id: ccdconfig.c,v 1.7 1997/06/10 11:04:50 charnier Exp $ */
/* $NetBSD: ccdconfig.c,v 1.2.2.1 1995/11/11 02:43:35 thorpej Exp $ */
@ -161,6 +161,15 @@ main(argc, argv)
if (options > 1)
usage();
/*
* Discard setgid privileges if not the running kernel so that bad
* guys can't print interesting stuff from kernel memory.
*/
if (core != NULL || kernel != NULL || action != CCD_DUMP) {
setegid(getgid());
setgid(getgid());
}
switch (action) {
case CCD_CONFIG:
case CCD_UNCONFIG:
@ -307,11 +316,16 @@ do_all(action)
char line[_POSIX2_LINE_MAX];
char *cp, **argv;
int argc, rval;
gid_t egid;
egid = getegid();
setegid(getgid());
if ((f = fopen(ccdconf, "r")) == NULL) {
setegid(egid);
warn("fopen: %s", ccdconf);
return (1);
}
setegid(egid);
while (fgets(line, sizeof(line), f) != NULL) {
argc = 0;