From 14b258b8066342dc82272f43ceb399ffc8ca7e35 Mon Sep 17 00:00:00 2001 From: Adrian Chadd Date: Sun, 5 Jun 2016 07:56:28 +0000 Subject: [PATCH] [bwn] Add missing firmware release calls. This trips me up whenever I'm fooling around with partially supported NICs that fail to fully attach or initialise - the firmware gets loaded and references, but something fails - and the firmware references aren't cleaned up. --- sys/dev/bwn/if_bwn.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/bwn/if_bwn.c b/sys/dev/bwn/if_bwn.c index 27f919474dd..4967af1d1dd 100644 --- a/sys/dev/bwn/if_bwn.c +++ b/sys/dev/bwn/if_bwn.c @@ -750,6 +750,7 @@ bwn_detach(device_t dev) if (mac->mac_msi != 0) pci_release_msi(dev); mbufq_drain(&sc->sc_snd); + bwn_release_firmware(mac); BWN_LOCK_DESTROY(sc); return (0); } @@ -1328,6 +1329,7 @@ bwn_attach_core(struct bwn_mac *mac) siba_dev_down(sc->sc_dev, 0); fail: siba_powerdown(sc->sc_dev); + bwn_release_firmware(mac); return (error); } @@ -3930,6 +3932,7 @@ bwn_fw_gets(struct bwn_mac *mac, enum bwn_fwtype type) } } else if (rev < 11) { device_printf(sc->sc_dev, "no PCM for rev %d\n", rev); + bwn_release_firmware(mac); return (EOPNOTSUPP); }