upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-08 16:22:46 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

dwc3: improve debugging

Browse source 
Rather than hiding behind #if 0, hide the debugging behind DWC3_DEBUG
so it can be turned on with a single define.  Require bootverbose
to print anything so we can still avoid spamming the console if DWC3_DEBUG
is on.
Harmonize the format string in snsp_dwc3_dump_regs() to always print the
full register and also print the XHCI quirks.
Call snsp_dwc3_dump_regs() twice, before and after generic XHCI attachment
and initialisation as this may have an effect on the confirgumation state.

Obtained from:	an old debug patch
MFC after:	2 weeks
Reviewed by:	mw
Differential Revision: https://reviews.freebsd.org/D35700
This commit is contained in:
Bjoern A. Zeeb 2022-07-02 21:10:00 +00:00
parent 09cdf4878c
commit 11a7d5e5d9
1 changed files with 24 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
sys/dev/usb/controller/dwc3.c
View file

@ -147,22 +147,33 @@ snps_dwc3_attach_xhci(device_t dev)
return (0);
}
#if 0
#ifdef DWC3_DEBUG
static void
snsp_dwc3_dump_regs(struct snps_dwc3_softc *sc)
snsp_dwc3_dump_regs(struct snps_dwc3_softc *sc, const char *msg)
{
struct xhci_softc *xsc;
uint32_t reg;
if (!bootverbose)
return;
device_printf(sc->dev, "%s: %s:\n", __func__, msg ? msg : "");
reg = DWC3_READ(sc, DWC3_GCTL);
device_printf(sc->dev, "GCTL: %x\n", reg);
device_printf(sc->dev, "GCTL: %#012x\n", reg);
reg = DWC3_READ(sc, DWC3_GUCTL);
device_printf(sc->dev, "GUCTL: %#012x\n", reg);
reg = DWC3_READ(sc, DWC3_GUCTL1);
device_printf(sc->dev, "GUCTL1: %x\n", reg);
device_printf(sc->dev, "GUCTL1: %#012x\n", reg);
reg = DWC3_READ(sc, DWC3_GUSB2PHYCFG0);
device_printf(sc->dev, "GUSB2PHYCFG0: %x\n", reg);
device_printf(sc->dev, "GUSB2PHYCFG0: %#012x\n", reg);
reg = DWC3_READ(sc, DWC3_GUSB3PIPECTL0);
device_printf(sc->dev, "GUSB3PIPECTL0: %x\n", reg);
device_printf(sc->dev, "GUSB3PIPECTL0: %#012x\n", reg);
reg = DWC3_READ(sc, DWC3_DCFG);
device_printf(sc->dev, "DCFG: %x\n", reg);
device_printf(sc->dev, "DCFG: %#012x\n", reg);
xsc = &sc->sc;
device_printf(sc->dev, "xhci quirks: %#012x\n", xsc->sc_quirks);
}
#endif
@ -384,10 +395,14 @@ snps_dwc3_attach(device_t dev)
snps_dwc3_configure_host(sc);
snps_dwc3_configure_phy(sc);
snps_dwc3_do_quirks(sc);
#if 0
snsp_dwc3_dump_regs(sc);
#ifdef DWC3_DEBUG
snsp_dwc3_dump_regs(sc, "Pre XHCI init");
#endif
snps_dwc3_attach_xhci(dev);
#ifdef DWC3_DEBUG
snsp_dwc3_dump_regs(sc, "Post XHCI init");
#endif
return (0);
}