upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-05-28 04:12:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[iwm] Fix iwm_poll_bit() error value check in iwm_attach().

Browse source 
The iwm(4) iwm_poll_bit() function returns 1 on success, and 0 on failure,
whereas the iwl_poll_bit() in Linux iwlwifi returns < 0 on failure.

So the (ret < 0) check ended up ignoring any error returned by
iwm_poll_bit().

Approved by:	adrian (mentor)
Differential Revision:	https://reviews.freebsd.org/D7932
This commit is contained in:
Imre Vadász 2016-09-19 22:13:08 +00:00
parent 739e99ba69
commit 0cd7fa558e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/dev/iwm/if_iwm.c
View file

@ -5762,7 +5762,7 @@ iwm_attach(device_t dev)
IWM_CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
IWM_CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
25000);
if (ret < 0) {
if (!ret) {
device_printf(sc->sc_dev,
"Failed to wake up the nic\n");
goto fail;