From 0bf993fcc18f4cbc0741bcdae258bc7372b363be Mon Sep 17 00:00:00 2001 From: "Alexander V. Chernikov" Date: Sun, 24 May 2015 11:24:14 +0000 Subject: [PATCH] Fix SIOCGI2C structure requirement. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In reality, SIOCGI2C ioctl requires struct ifreq as many other ioctls. Doing copyin() on (significantly) larger struct ifstat sometimes triggered EFAULT. Reported by: Olivier Cochard-Labbé MFC after: 1 week --- sys/sys/sockio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/sockio.h b/sys/sys/sockio.h index 8624ad2e3b1..73ebf5f1c94 100644 --- a/sys/sys/sockio.h +++ b/sys/sys/sockio.h @@ -96,7 +96,7 @@ #define SIOCGIFSTATUS _IOWR('i', 59, struct ifstat) /* get IF status */ #define SIOCSIFLLADDR _IOW('i', 60, struct ifreq) /* set linklevel addr */ -#define SIOCGI2C _IOWR('i', 61, struct ifstat) /* get I2C data */ +#define SIOCGI2C _IOWR('i', 61, struct ifreq) /* get I2C data */ #define SIOCSIFPHYADDR _IOW('i', 70, struct ifaliasreq) /* set gif addres */ #define SIOCGIFPSRCADDR _IOWR('i', 71, struct ifreq) /* get gif psrc addr */