From 09f49f249a8baeadb58d22ab06735c88e75b99c1 Mon Sep 17 00:00:00 2001 From: Conrad Meyer Date: Sat, 24 Oct 2015 23:45:21 +0000 Subject: [PATCH] ioat: When queueing operations, assert the submit lock Callers should have acquired this lock when they invoked ioat_acquire() before issuing operations. Assert it is held. Sponsored by: EMC / Isilon Storage Division --- sys/dev/ioat/ioat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/ioat/ioat.c b/sys/dev/ioat/ioat.c index cd372eee25a..4a5dde33951 100644 --- a/sys/dev/ioat/ioat.c +++ b/sys/dev/ioat/ioat.c @@ -641,6 +641,7 @@ ioat_null(bus_dmaengine_t dmaengine, bus_dmaengine_callback_t callback_fn, flags & ~DMA_ALL_FLAGS)); ioat = to_ioat_softc(dmaengine); + mtx_assert(&ioat->submit_lock, MA_OWNED); if (ioat_reserve_space_and_lock(ioat, 1) != 0) return (NULL); @@ -681,6 +682,7 @@ ioat_copy(bus_dmaengine_t dmaengine, bus_addr_t dst, flags & ~DMA_ALL_FLAGS)); ioat = to_ioat_softc(dmaengine); + mtx_assert(&ioat->submit_lock, MA_OWNED); if (len > ioat->max_xfer_size) { ioat_log_message(0, "%s: max_xfer_size = %d, requested = %d\n",