upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-14 19:20:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

- Only touch the LED bit of the (LED) AUXIO register when turning the

Browse source 
system LED on or off. Unlike the EBus LED AUXIO register where the
  remaining bits are unused the upper bits of the SBus AUXIO register
  are used to control other things like the link test enable pin of
  the on-board NIC which we don't want to change as a side-effect.
- Remove the superfluous bzero()'ing of the softc obtained from
  device_get_softc().

Reviewed by:	yongari
MFC after:	3 days
This commit is contained in:
Marius Strobl 2006-01-26 19:04:18 +00:00
parent 668816ed50
commit 0574df71dc
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
sys/dev/auxio/auxio.c
View file

@ -200,8 +200,15 @@ auxio_led_func(void *arg, int onoff)
sc = (struct auxio_softc *)arg;
led = onoff ? AUXIO_LED_LED : 0;
AUXIO_LOCK(sc);
/*
* NB: We must not touch the other bits of the SBus AUXIO reg.
*/
led = auxio_led_read(sc);
if (onoff)
led |= AUXIO_LED_LED;
else
led &= ~AUXIO_LED_LED;
auxio_led_write(sc, led);
AUXIO_UNLOCK(sc);
}
@ -226,7 +233,6 @@ auxio_ebus_attach(device_t dev)
struct auxio_softc *sc;
sc = device_get_softc(dev);
bzero(sc, sizeof(*sc));
sc->sc_dev = dev;
AUXIO_LOCK_INIT(sc);
@ -256,7 +262,7 @@ auxio_attach_common(struct auxio_softc *sc)
sc->sc_regh[i] = rman_get_bushandle(res);
}
sc->sc_led_stat = auxio_led_read(sc);
sc->sc_led_stat = auxio_led_read(sc) & AUXIO_LED_LED;
sc->sc_led_dev = led_create(auxio_led_func, sc, "auxioled");
/* turn on the LED */
auxio_led_func(sc, 1);
@ -300,7 +306,6 @@ auxio_sbus_attach(device_t dev)
struct auxio_softc *sc;
sc = device_get_softc(dev);
bzero(sc, sizeof(*sc));
sc->sc_dev = dev;
AUXIO_LOCK_INIT(sc);