upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-04-23 23:28:37 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

netgraph/ng_base: Renaming a node to the same name is a noop

Browse source 
Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move.  Because the name of the node is already known
(occupied by itself), the second call fails.

PR:		241954
Reported by:	Paul Armstrong
MFC:		1 week
Differential Revision: https://reviews.freebsd.org/D30110
This commit is contained in:
Lutz Donnerhacke 2021-05-04 21:20:39 +02:00
parent 9b236631b1
commit 0345fd891f
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sys/netgraph/ng_base.c
View file

@ -855,6 +855,10 @@ ng_name_node(node_p node, const char *name)
node_p node2;
int i;
/* Rename without change is a noop */
if (strcmp(NG_NODE_NAME(node), name) == 0)
return (0);
/* Check the name is valid */
for (i = 0; i < NG_NODESIZ; i++) {
if (name[i] == '\0' || name[i] == '.' || name[i] == ':')