upstream/opnsense-src
1
0
Fork 0
mirror of https://github.com/opnsense/src.git synced 2026-06-11 01:30:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

cache: add back target entry on rename

Browse source
This commit is contained in:
Mateusz Guzik 2021-01-23 18:21:42 +01:00
parent d7dd28bb09
commit 02ec31bdf6
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
sys/kern/vfs_cache.c
View file

@ -367,6 +367,10 @@ static bool __read_frequently cache_fast_revlookup = true;
SYSCTL_BOOL(_vfs, OID_AUTO, cache_fast_revlookup, CTLFLAG_RW,
&cache_fast_revlookup, 0, "");
static bool __read_mostly cache_rename_add = true;
SYSCTL_BOOL(_vfs, OID_AUTO, cache_rename_add, CTLFLAG_RW,
&cache_rename_add, 0, "");
static u_int __exclusive_cache_line neg_cycle;
#define ncneghash 3
@ -2731,6 +2735,21 @@ cache_vop_rename(struct vnode *fdvp, struct vnode *fvp, struct vnode *tdvp,
} else {
cache_remove_cnp(tdvp, tcnp);
}
/*
* TODO
*
* Historically renaming was always purging all revelang entries,
* but that's quite wasteful. In particular turns out that in many cases
* the target file is immediately accessed after rename, inducing a cache
* miss.
*
* Recode this to reduce relocking and reuse the existing entry (if any)
* instead of just removing it above and allocating a new one here.
*/
if (cache_rename_add) {
cache_enter(tdvp, fvp, tcnp);
}
}
void