From 00742f6ced54eb680e7cd1dffc7c73e703958ca6 Mon Sep 17 00:00:00 2001 From: Dimitry Andric Date: Sat, 7 Jan 2017 15:57:12 +0000 Subject: [PATCH] Fix the following clang 4.0.0 warning in ngatm's snmp_atm.c: contrib/ngatm/snmp_atm/snmp_atm.c:173:6: error: logical not is only applied to the left hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses] if (!ifmr.ifm_status & IFM_AVALID) { ^ ~ Obviously, the masking needs to be done before the logical not operation. Add parentheses to make it so. MFC after: 3 days --- contrib/ngatm/snmp_atm/snmp_atm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ngatm/snmp_atm/snmp_atm.c b/contrib/ngatm/snmp_atm/snmp_atm.c index c922c6f3dd7..a2590aeb4dd 100644 --- a/contrib/ngatm/snmp_atm/snmp_atm.c +++ b/contrib/ngatm/snmp_atm/snmp_atm.c @@ -170,7 +170,7 @@ atmif_check_carrier(struct atmif_priv *aif) aif->pub.carrier = ATMIF_CARRIER_UNKNOWN; return; } - if (!ifmr.ifm_status & IFM_AVALID) { + if (!(ifmr.ifm_status & IFM_AVALID)) { aif->pub.carrier = ATMIF_CARRIER_UNKNOWN; return; }