opnsense-src/lib/libc/tests/iconv/Makefile

# $FreeBSD$

TESTSDIR=	${TESTSBASE}/lib/libc/iconv

ATF_TESTS_C+=	iconvctl_test
WARNS?=		2

.include <bsd.test.mk>
iconvctl(3): remove superfluous NULL pointer tests convname and dst are guaranteed to be non-NULL by iconv_open(3). src is an array. Remove these tests for NULL pointers. While I'm here, eliminate a strlcpy with a correct but suspicious-looking calculation for the third parameter (i.e. not a simple sizeof). Compare the strings in-place instead of copying. Found by: bdrewery Found by: Coverity CID: 1130050, 1130056 MFC after: 3 days Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D6338 2016-05-13 20:35:35 -04:00			`# $FreeBSD$`

			`TESTSDIR= ${TESTSBASE}/lib/libc/iconv`

			`ATF_TESTS_C+= iconvctl_test`
Increase WARNS for iconv tests ATF tests have a default WARNS of 0, unlike other usermode programs. Reviewed by: ngie MFC after: 3 weeks Sponsored by: Spectra Logic Corporation Differential Revision: https://reviews.freebsd.org/D9933 2017-03-10 19:02:05 -05:00			`WARNS?= 2`
iconvctl(3): remove superfluous NULL pointer tests convname and dst are guaranteed to be non-NULL by iconv_open(3). src is an array. Remove these tests for NULL pointers. While I'm here, eliminate a strlcpy with a correct but suspicious-looking calculation for the third parameter (i.e. not a simple sizeof). Compare the strings in-place instead of copying. Found by: bdrewery Found by: Coverity CID: 1130050, 1130056 MFC after: 3 days Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D6338 2016-05-13 20:35:35 -04:00
			`.include <bsd.test.mk>`