net/ftp-proxy: use model for easier iteration code

PR: https://github.com/opnsense/plugins/issues/52
Suggested by: @adschellevis
This commit is contained in:
Franco Fichtner 2016-11-14 07:38:39 +01:00
parent 2b62ed430f
commit f8e86531ed

View file

@ -28,22 +28,14 @@
function ftpproxy_enabled()
{
global $config;
$model = new \OPNsense\FtpProxy\FtpProxy();
if (isset($config['OPNsense']['ftpproxies']['ftpproxy'][0])) {
foreach ($config['OPNsense']['ftpproxies']['ftpproxy'] as $ftpproxy) {
if (isset($ftpproxy['enabled']) && $ftpproxy['enabled']) {
return true;
}
foreach ($model->ftpproxy->__items as $server) {
if ($server->enabled == '1') {
return true;
}
}
/* we should always make arrays for these, too many potential bugs: */
if (isset($config['OPNsense']['ftpproxies']['ftpproxy']['enabled']) &&
$config['OPNsense']['ftpproxies']['ftpproxy']['enabled']) {
return true;
}
return false;
}