upstream/opnsense-plugins
1
0
Fork 0
mirror of https://github.com/opnsense/plugins.git synced 2026-06-04 22:33:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ditch xml2array in phpDynDNS.inc, for https://github.com/opnsense/plugins/issues/269

Browse source
This commit is contained in:
Ad Schellevis 2017-09-16 18:02:51 +02:00
parent ff5692e278
commit da5ae3c452
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
dns/dyndns/src/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc
View file

@ -939,16 +939,19 @@ class updatedns {
break;
case 'namecheap':
$tmp = str_replace("^M", "", $data);
$ncresponse = @xml2array($tmp);
$ncresponse = simplexml_load_string($tmp);
if (preg_match("/internal server error/i", $data)) {
$status = "Dynamic DNS: (Error) Server side error.";
} else if (preg_match("/request is badly formed/i", $data)) {
} elseif (preg_match("/request is badly formed/i", $data)) {
$status = "Dynamic DNS: (Error) Badly Formed Request (check your settings).";
} else if ($ncresponse['interface-response']['ErrCount'] === "0") {
} elseif ((string)$ncresponse->ErrCount === "0") {
$status = "Dynamic DNS: (Success) IP Address Updated Successfully!";
$successful_update = true;
} else if (is_numeric($ncresponse['interface-response']['ErrCount']) && ($ncresponse['interface-response']['ErrCount'] > 0)) {
$status = "Dynamic DNS: (Error) " . implode(", ", $ncresponse["interface-response"]["errors"]);
} elseif (is_numeric((string)$ncresponse->ErrCount) && (string)$ncresponse->ErrCount > 0) {
$status = "Dynamic DNS: (Error) ";
foreach ($xml->errors->children() as $err) {
$status .= (string)$err . " ";
}
$successful_update = true;
} else {
$status = "Dynamic DNS: (Unknown Response)";