From a19de553aa2d1760ec73b034c28734539d8e3ece Mon Sep 17 00:00:00 2001 From: lin-xianming <108489988+lin-xianming@users.noreply.github.com> Date: Sun, 25 Feb 2024 05:05:30 -0500 Subject: [PATCH] ddclient: Cloudflare - update DNS record instead of overwriting (#3837) Updating the record preserves proxied status, TTL, comment, and such. --- .../src/opnsense/scripts/ddclient/lib/account/cloudflare.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/cloudflare.py b/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/cloudflare.py index 1fd15ada8..f5bd716ba 100755 --- a/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/cloudflare.py +++ b/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/cloudflare.py @@ -142,7 +142,6 @@ class Cloudflare(BaseAccount): return False record_id = payload['result'][0]['id'] - proxied = payload['result'][0]['proxied'] if self.is_verbose: syslog.syslog( syslog.LOG_NOTICE, @@ -156,11 +155,10 @@ class Cloudflare(BaseAccount): 'type': recordType, 'name': self.settings.get('hostnames'), 'content': str(self.current_address), - 'proxied': proxied }, 'headers': req_opts['headers'] } - response = requests.put(**req_opts) + response = requests.patch(**req_opts) try: payload = response.json() except requests.exceptions.JSONDecodeError: