From 6ee1662386d6fecc52525bedcd5b9a83a5ebc908 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Fri, 23 Aug 2019 13:55:21 +0200 Subject: [PATCH] sysutils/smart: consistency is futile #1384 --- .../opnsense/scripts/OPNsense/Smart/detailed_list.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sysutils/smart/src/opnsense/scripts/OPNsense/Smart/detailed_list.sh b/sysutils/smart/src/opnsense/scripts/OPNsense/Smart/detailed_list.sh index d80625b45..d8a3b55c1 100755 --- a/sysutils/smart/src/opnsense/scripts/OPNsense/Smart/detailed_list.sh +++ b/sysutils/smart/src/opnsense/scripts/OPNsense/Smart/detailed_list.sh @@ -27,10 +27,16 @@ RESULT= -for DEV in $(sysctl -n kern.disks | sed s:nvd:nvme:g); do - STATE=$(/usr/local/sbin/smartctl -jH /dev/${DEV}) +for DEV in $(sysctl -n kern.disks); do IDENT=$(/usr/sbin/diskinfo -s ${DEV}) + if [ "${DEV#nvd}" != "${DEV}" ]; then + # the disk formerly know as nvdX + DEV="nvme${DEV#nvd}" + fi + + STATE=$(/usr/local/sbin/smartctl -jH /dev/${DEV}) + if [ -n "${RESULT}" ]; then RESULT="${RESULT},"; fi